RoyaleAPI / cr-api

Clash Royale Analytics, Profiles and Insights. We no longer publish a public API. Please use the official API from Supercell.
https://RoyaleAPI.com
167 stars 20 forks source link

Tournaments data outdated and inefficient pagination #430

Closed gogaz closed 5 years ago

gogaz commented 5 years ago

Issue Report:

  1. Did you encounter this recently, or has this bug always been there? I started working with tournaments yestarday. Pagination didn't seem to work but tournaments data looked up to date
  2. Encountered behaviour: /tournaments/joinable, /tournaments/open and /tournaments/1k both return the exact same data which is outdated regardless of the page argument.

Below createTime indicates 20 September 08:21:34 UTC and updatedAt refers to 08:22:58 UTC

Request Details:

GET
https://api.royaleapi.com/tournaments/open
https://api.royaleapi.com/tournaments/open?page=10

Response Details:

Code: 200
[
    {
        "tag": "URQ0CL9",
        "name": "iran2",
        "open": true,
        "maxPlayers": 1000,
        "currentPlayers": 1,
        "status": "inPreparation",
        "createTime": 1537431694,
        "prepTime": 7200,
        "startTime": null,
        "endTime": null,
        "duration": 3600,
        "description": "",
        "updatedAt": 1537431778,
        "members": []
    },
...
]

Code: 200
[
    {
        "tag": "URQ0CL9",
        "name": "iran2",
        "open": true,
        "maxPlayers": 1000,
        "currentPlayers": 1,
        "status": "inPreparation",
        "createTime": 1537431694,
        "prepTime": 7200,
        "startTime": null,
        "endTime": null,
        "duration": 3600,
        "description": "",
        "updatedAt": 1537431778,
        "members": []
    },
...
]
gogaz commented 5 years ago

The data seems fresh now but the pagination is still not working

fourjr commented 5 years ago

Duplicate of #407