RoyaleAPI / cr-api

Clash Royale Analytics, Profiles and Insights. We no longer publish a public API. Please use the official API from Supercell.
https://RoyaleAPI.com
167 stars 20 forks source link

Missing location code for Oceania clan locations #447

Closed jonowo closed 5 years ago

jonowo commented 5 years ago

Issue Report:

  1. I encountered this today, no idea if it was there before.
  2. Expected behaviour: "code": "_AU" is present in clan["location"]. (Location code for Oceania is _AU)
  3. This only happens to Oceania clans retrieved from /clan, /top/clans and /top/war, not to clans in other regions such as Asia.

Request Details:

GET
https://api.royaleapi.com/clan/89YVRV
https://api.royaleapi.com/top/clans
https://api.royaleapi.com/top/war

Response Details:

/clan/89YVRV (some data is omitted):

Code: 200
{
  "tag": "89YVRV",
  "name": "DBZ Saiyans",
  "description": ...,
  "type": "open",
  "score": 51050,
  "warTrophies": 8971,
  "memberCount": 46,
  "requiredScore": 4900,
  "donations": 28006,
  "badge": {...},
  "location": {
    "name": "Oceania",
    "isCountry": false
  },
  "members": [...],
  "tracking": {...}
}

/top/clans and /top/war (similar response, some data is omitted):

Code: 200
[
  ...,
  {
    "tag": "89YVRV",
    "name": "DBZ Saiyans",
    "score": 8971,
    "memberCount": 46,
    "rank": ...,
    "previousRank": ...,
    "badge": {...},
    "location": {
      "name": "Oceania",
      "isCountry": false
    }
  },
  ...
]
selfish commented 5 years ago

It has no location code AFAIK, and doesn't exist in the official API. Feel free to reopen with details if I'm incorrect.