RoyaleAPI / cr-api

Clash Royale Analytics, Profiles and Insights. We no longer publish a public API. Please use the official API from Supercell.
https://RoyaleAPI.com
166 stars 20 forks source link

Pagination (page) for clan search not working #454

Closed MrBartusek closed 3 years ago

MrBartusek commented 5 years ago

Hello for some reason when I request for clan search paginations seams to not work

Request Details:

GET
api.royaleapi.com/clan/search?name=xyz&max=3
or GET
api.royaleapi.com/clan/search?name=xyz&max=3&page=1
or GET
api.royaleapi.com/clan/search?name=xyz&max=3&page=2

Response Details:

Code: 200
[
  {
    "tag": "V0229J",
    "name": "XYZ",
    "type": "open",
    "score": 35744,
    "memberCount": 33,
    "requiredScore": 3000,
    "donations": 2662,
    "badge": {
      "name": "Freeze_01",
      "category": "01_Symbol",
      "id": 16000168,
      "image": "https://royaleapi.github.io/cr-api-assets/badges/Freeze_01.png"
    },
    "location": {
      "name": "Saudi Arabia",
      "isCountry": true,
      "code": "SA"
    }
  },
  {
    "tag": "P2GCGJU0",
    "name": "XYZ",
    "type": "open",
    "score": 9456,
    "memberCount": 8,
    "requiredScore": 2000,
    "donations": 98,
    "badge": {
      "name": "flag_e_02",
      "category": "02_Flag",
      "id": 16000173,
      "image": "https://royaleapi.github.io/cr-api-assets/badges/flag_e_02.png"
    },
    "location": {
      "name": "Indonesia",
      "isCountry": true,
      "code": "ID"
    },
    "tracking": {
      "active": false,
      "available": false,
      "snapshotCount": 0
    }
  },
  {
    "tag": "PPPL9YPJ",
    "name": "XYZ",
    "type": "open",
    "score": 4618,
    "memberCount": 4,
    "requiredScore": 0,
    "donations": 12,
    "badge": {
      "name": "Bamboo_04",
      "category": "01_Symbol",
      "id": 16000139,
      "image": "https://royaleapi.github.io/cr-api-assets/badges/Bamboo_04.png"
    },
    "location": {
      "name": "International",
      "isCountry": false,
      "code": "_INT"
    },
    "tracking": {
      "active": false,
      "available": false,
      "snapshotCount": 0
    }
  }
]

This response is returned for all of the endpoints but it shouldn't

Moosphan commented 5 years ago

I found the same problem

selfish commented 4 years ago

@MrBartusek @Moosphan Is this realted to v2 or v3? At the moment, v2 is unmaintained, and v3 should support pagination later on down the line.

MrBartusek commented 4 years ago

@MrBartusek @Moosphan Is this realted to v2 or v3? At the moment, v2 is unmaintained, and v3 should support pagination later on down the line.

I don't really remember but i think i wrote that issue when v3 docs had pagination for some reason, thanks for reply

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.