search

Royston1999 / ScorePercentage-Quest

a mod that shows extra information about your score and more
7 stars 0 forks source link

Advance configs are not saved and have no effect #3

Closed jk4837 closed 2 years ago

jk4837 commented 2 years ago

Those configurations for "Advanced Score Details Settings > Show XXX" are not saved and not displayed in the ui.

Royston1999 commented 2 years ago

for the extra data to be saved and loaded into the UI, you must set a new highscore on a map (any maps played before the mod's installation will not have the extra details). since I am unable to reproduce this myself, would you be able to provide screenshots of things not working? so setting a new highscore on a map, and then nothing showing up in the UI

jk4837 commented 2 years ago

Ok, I have make some video clip.

Royston1999 commented 2 years ago

Oh wow that is really strange. My current theory is that the mod somehow failed when initially creating the config file. Would you be able to send a screenshot of what the scorepercentage.json file looks like? I apologise for the bug. I've never seen this happen before

jk4837 commented 2 years ago

Where is scorepercentage.json? Do you mean storage\ModData\com.beatgames.beatsaber\Mods\scorepercentage\beatMapData.json?

Royston1999 commented 2 years ago

It should be at storage\ModData\com.beatgames.beatsaber\Configs\scorepercentage.json I believe

jk4837 commented 2 years ago

Does not exist. image

Royston1999 commented 2 years ago

I see another file there called ScorePercentage.json Is that mine? If not that is almost definitely conflicting with the mod

jk4837 commented 2 years ago

I remove ScorePercentage.json and works perfect now! I think the file may have been created by the old mod, I downloaded the code of the old mod made by Futur a few days ago and upgraded it to be compatible with BS 1.17.1.

Btw, will you mind to get an issue for feature request?

Royston1999 commented 2 years ago

I knew it! Since I copied futur's stuff initially so the configs were conflicting with each other. I'm glad everything's working now. You want to suggest a feature? Sure!

jk4837 commented 2 years ago

Thanks for your help!