RoystonS / BetterBravoLights

Utility for controlling lights on a Honeycomb Bravo Throttle from Microsoft Flight Simulator
MIT License
42 stars 8 forks source link

Starter Engaged annunciated light fix #12

Closed JimHerrod closed 2 years ago

JimHerrod commented 2 years ago

I noticed that the annunciator light for Starter Engaged is not tied to the actual starter switch. It is tied to the engine master switch. I.E. the light won't come on until the engine master is switched on regardless of the condition of the starter switch.

I was able to fix this by making the below changes...

Original code...

StarterEngaged = A:GENERAL ENG STARTER:1, bool == 1 || A:GENERAL ENG STARTER:2, bool == 1 || A:GENERAL ENG STARTER:3, bool == 1 || A:GENERAL ENG STARTER:4, bool == 1

New code...

StarterEngaged = A:TURB ENG IGNITION SWITCH EX1:1, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:2, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:3, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:4, bool == 2

I have tested and the light now comes on when the switch is set to Start, and turns off when it is moved to any other condition (normal or crank)

I only fly the FBW A32NX, so haven't tested with any other aircraft, but I think it should work with any of them.

RoystonS commented 2 years ago

Thanks for the report!

Very interesting. I based the original configuration for that light on the configuration that came with the original Bravo lights, which used A:GENERAL ENG STARTER:1.

I've just tried a Cessna 152, and upon turning the starter key, I see this: image

So only using the TURB ENG IGNITION SWITCH EX1 values wouldn't work for the Cessna 152: that definitely needs A:GENERAL ENG STARTER:1.

I've just tried in the stock A320neo and can see that, as you say, the engine master switches drive the values of A:GENERAL ENG STARTER:n and the ignition control mode knob drives A:TURB ENG IGNITION SWITCH EX1:n, with a value of 0 for 'CRANK', 1 for 'NORM' and 2 for 'IGN/START'.

I had thought about using the combined expression A:GENERAL ENG STARTER:1, bool == 1 || A:GENERAL ENG STARTER:2, bool == 1 || A:GENERAL ENG STARTER:3, bool == 1 || A:GENERAL ENG STARTER:4, bool == 1 || A:TURB ENG IGNITION SWITCH EX1:1, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:2, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:3, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:4, bool == 2 to check for any of them, but I don't think it would make any sense to include A:GENERAL ENG STARTER:n on the A320s because you don't want the starter light lit simply because the engine master switches are on. I'm not an A320 flier, so is that right?

If that's correct, I think we need aircraft-specific configurations, with configuration as you suggest.

JimHerrod commented 2 years ago

Thanks for the reply and I’m glad you found my feedback useful. Yes, you are correct that the starter light shouldn’t come on just because the engine masters are on in the A320.

Also, just an FYI, I left a couple private messages via flightsim.to. You can disregard the message about setting the backlighting on the AP buttons to be always on. I was able to solve that by changing a couple bool values. I am still not sure about the install error I’m getting, which isn’t a huge deal since I have been running the standalone executable. The installer seems to be looking for an exe.xml file somewhere. I attached a screenshot to the flightsim.to message. It would be nice to run the install so I don’t have to close the exe through task manager.

Feel free to contact me if you have any questions.

On Oct 11, 2021, at 2:16 PM, Royston Shufflebotham @.***> wrote:

 Thanks for the report!

Very interesting. I based the original configuration for that light on the configuration that came with the original Bravo lights, which used A:GENERAL ENG STARTER:1.

I've just tried a Cessna 152, and upon turning the starter key, I see this:

So only using the TURB ENG IGNITION SWITCH EX1 values wouldn't work for the Cessna 152: that definitely needs A:GENERAL ENG STARTER:1.

I've just tried in the stock A320neo and can see that, as you say, the engine master switches drive the values of A:GENERAL ENG STARTER:n and the ignition control mode knob drives A:TURB ENG IGNITION SWITCH EX1:n, with a value of 0 for 'CRANK', 1 for 'NORM' and 2 for 'IGN/START'.

I had thought about using the combined expression A:GENERAL ENG STARTER:1, bool == 1 || A:GENERAL ENG STARTER:2, bool == 1 || A:GENERAL ENG STARTER:3, bool == 1 || A:GENERAL ENG STARTER:4, bool == 1 || A:TURB ENG IGNITION SWITCH EX1:1, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:2, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:3, bool == 2 || A:TURB ENG IGNITION SWITCH EX1:4, bool == 2 to check for any of them, but I don't think it would make any sense to include A:GENERAL ENG STARTER:n on the A320s because you don't want the starter light lit simply because the engine master switches are on. I'm not an A320 flier, so is that right?

If that's correct, I think we need aircraft-specific configurations, with configuration as you suggest.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

RoystonS commented 2 years ago

Hi @JimHerrod.

I'll make the changes to the default configuration for the A320neo + A32NX.

Thanks for the pointer about the private messages - that was a flightsim.to facility I didn't know about!

I'll raise the installer failure as a separate issue.

The logic right now is:

If you run the app by itself without installing it, it'll stay running until you manually exit it. If you install the app (i.e. arrange for MSFS to launch the app), it'll automatically shut itself down when MSFS exits.

RoystonS commented 2 years ago

Hi @JimHerrod I've just released v0.4.3 which includes your config change for the A320neo and FBW A32NX. Thanks again!

JimHerrod commented 2 years ago

Awesome! Glad I was able to help. Does the new version also remedy the installer issue?

Sent from Mail for Windows

From: Royston Shufflebotham Sent: Monday, October 11, 2021 5:10 PM To: RoystonS/BetterBravoLights Cc: JimHerrod; Mention Subject: Re: [RoystonS/BetterBravoLights] Starter Engaged annunciated light fix (#12)

Hi @JimHerrod I've just released v0.4.3 which includes your config change for the A320neo and FBW A32NX. Thanks again! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

JimHerrod commented 2 years ago

I just answered my own question. Yes, the installer now works in 0.4.3. Great job!

Sent from Mail for Windows

From: Royston Shufflebotham Sent: Monday, October 11, 2021 5:10 PM To: RoystonS/BetterBravoLights Cc: JimHerrod; Mention Subject: Re: [RoystonS/BetterBravoLights] Starter Engaged annunciated light fix (#12)

Hi @JimHerrod I've just released v0.4.3 which includes your config change for the A320neo and FBW A32NX. Thanks again! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

RoystonS commented 2 years ago

Yep, I covered that one in a separate issue: #13 Delighted to hear it worked!