RozeFound / mmc-export

Export MMC modpack to other modpack formats
MIT License
15 stars 3 forks source link

Don't spam about GitHub auth #33

Closed Madis0 closed 2 years ago

Madis0 commented 2 years ago

But, every launch you will be asked to authorize yourself with simple instructions to avoid the limit, once you authorize, it will store token in secure keyring and stop asking.

This is unnecessary, because the readme already talks about the benefits of authenticating and what will happen if the user won't authenticate.

Instead, I recommend creating a command like mmc-export gh-login which will do it when the user requests that. Similarly, mmc-export gh-logout.

Edit: As of 2.2.1 it seems the script won't continue at all until I do authenticate with GitHub 😢