RozeFound / mmc-export

Export MMC modpack to other modpack formats
MIT License
15 stars 3 forks source link

First launch showed weird data for GitHub #38

Closed Madis0 closed 2 years ago

Madis0 commented 2 years ago

I updated to 2.3.0 and got this message after first launch:

58/60 GitHub searches remaining, after that only cached results will be used. To get more searches, sign in with mmc-export gh-login or wait until 21:14 to get 60 searches again.

1) Where are the two searches already if I ran this the first time today? 2) "Wait until" literally told me the time at which I ran the command

The next launches are detailed on #39

RozeFound commented 2 years ago

Actually check runs after all requests are made, so your 2 searches is gone to it. Second is weird, maybe some GitHub API issue...

Madis0 commented 2 years ago

But if my 2 searches were gone, why does it not display 57 afterwards and instead displays 59? (#39 )

RozeFound commented 2 years ago

¯\_(ツ)_/¯

Madis0 commented 2 years ago

Okay, gonna close it until I can reproduce it again, perhaps more consistently.