search

RozeFound / mmc-export

Export MMC modpack to other modpack formats
MIT License
16 stars 3 forks source link

Config ignores plain files #65

Closed Madis0 closed 1 year ago

Madis0 commented 1 year ago

I made an empty file "Copy all 3 folders!" (yes, it has an exclamation mark and no file extension) and defined mmc-export.toml as

[[Resource]]
name = "Copy all 3 folders!"
filename = "Copy all 3 folders!"
action = "remove"

mmc-export did not ignore the file.

RozeFound commented 1 year ago

It doesn't dislike weird filenames, it's just don't do shit about plain files ¯\(ツ)\\/¯ This filed is for downloadable resources what you can guess by label [[Resource]], which is mods, resource-packs and shader-packs So that's why your file wasn't noticed by config parser

Madis0 commented 1 year ago

Ehhhhh... makes sense, but y'know, would be nice to use "remove" for any file 😆

RozeFound commented 1 year ago

I thought users won't include files thy don't need in the first place, during exporting an MMC pack, but... Well, I can add an option to remove any file

RozeFound commented 1 year ago

Can I ask you to update description before I publish it to pip?