Make the human form for Witchery Integration werewolves be MCA villagers if MCA is installed

[Rozmir-Rohi]

i noticed, the reason i ask is that they turn from like the human looking man into villagers ... hmmm would it be possible to customize what they turn back into? (could make it minecraft comes alive villagers ;0)

Originally posted by @brandyyn in https://github.com/Rozmir-Rohi/mo-creatures-legacy/issues/39#issuecomment-1943800752

[brandyyn]

Request: Change name to DrRozmir's Mo Creatures

[Rozmir-Rohi]

Added feature "make Witchery integration werewolves use human model and Minecraft Comes Alive textures if both Witchery and Minecraft Comes Alive are installed" with recent commits.

[brandyyn]

Added feature "make Witchery integration werewolves use human model and Minecraft Comes Alive textures if both Witchery and Minecraft Comes Alive are installed" with recent commits.

let me test GOOD !!! maybe they should attack the villagers too? what happens if witchery isn't installed? not sure how witchery is related tho

[Rozmir-Rohi]

They don't attack other werewolf villagers. But they do attack normal villagers when they are in werewolf form (and if world difficulty is not peaceful).

I'm not making it so that they attack villagers in human form, this is so that they can live in villages unnoticed while in human form.

If Witchery isn't installed there won't be any Minecraft Comes Alive werewolves, because the feature currently works by replacing Witchery werewolves and Witchery werewolf villagers.

Come to think of it, I'm not sure if the werewolf villagers from Witchery spawn naturally if MCA is installed because MCA replaces all normal Minecraft villagers, and this would then stop Witchery from replacing some of the spawned villagers with their villager werewolf, which then stops Mo' Creatures Legacy from replacing them with Minecraft Comes Alive werewolves.

I'll add a feature so that MCA werewolf villagers spawn without having to replace Witchery werewolf villagers.

[brandyyn]

They don't attack other werewolf villagers. But they do attack normal villagers when they are in werewolf form (and if world difficulty is not peaceful).

I'm not making it so that they attack villagers in human form, this is so that they can live in villages unnoticed while in human form.

If Witchery isn't installed there won't be any Minecraft Comes Alive werewolves, because the feature currently works by replacing Witchery werewolves and Witchery werewolf villagers.

Come to think of it, I'm not sure if the werewolf villagers from Witchery spawn naturally if MCA is installed because MCA replaces all normal Minecraft villagers, and this would then stop Witchery from replacing some of the spawned villagers with their villager werewolf, which then stops Mo' Creatures Legacy from replacing them with Minecraft Comes Alive werewolves.

I'll add a feature so that MCA werewolf villagers spawn without having to replace Witchery werewolf villagers.

Witchery villages override MCA villages, in my pack I have it so MCA villagers spawn in castles from Walled City Generator.

[Rozmir-Rohi]

This may take some time, but could you please do a test to see if you can find any naturally spawned MCA werewolf villagers in the villages so that I can confirm whether or not I need to add the "MCA werewolf villagers spawn without having to replace Witchery werewolf villagers" feature? The results for 5 villages in 5 worlds is enough (doesn't matter if the worlds have the same seed).

You can tell MCA werewolf villagers apart from MCA villagers using damage indicators because the entity name for MCA werewolf villagers is "Villager".

[brandyyn]

This may take some time, but could you please do a test to see if you can find any naturally spawned MCA werewolf villagers in the villages so that I can confirm whether or not I need to add the "MCA werewolf villagers spawn without having to replace Witchery werewolf villagers" feature? The results for 5 villages in 5 worlds is enough (doesn't matter if the worlds have the same seed).

You can tell MCA werewolf villagers apart from MCA villagers using damage indicators because the entity name for MCA werewolf villagers is "Villager".

can i ask how it's supposed to work? i haven't tested anything regarding this yet but in my pack all villages are witchery villages with normal villagers, then i have giant castles with MCA.EntityHuman spawners in them which spawns the MCA villagers, is it meant to replace 1 in x MCA villagers as they spawn? or are they meant to generate with the village?

[Rozmir-Rohi]

Never mind, don't do this test.

Looking more into this, I don't think Witchery werewolf villagers spawn naturally in villages.

Witchery integration werewolves spawn in two ways: 1 - By replacing a Witchery default werewolf if it is found in a world (spawns integration werewolf in werewolf form) 2 - By replacing a Witchery default werewolf villager if it is found in a world (spawns integration werewolf in human form)

I know that in Witchery, werewolf villagers can definitely be created if a werewolf kills a normal Minecraft villager, but with the replaceWitcheryWerewolfEntities set to true this won't happen.

If they don't spawn in villages, the only way you will encounter a werewolf villager with replaceWitcheryWerewolfEntities set to true will be when a Witchery integration werewolf that spawned by replacing a Witchery default werewolf turns back into human form.

[brandyyn]

do normal mo creatures werewolves still spawn naturally during the night?

[Rozmir-Rohi]

yes

[Rozmir-Rohi]

Since Witchery werewolf villagers don't spawn in villages by default, I'll add a config option that controls whether Witchery integration werewolf villagers have a small chance to spawn in villages. These will also be MCA werewolf villagers if MCA is installed.

This feature will work in the following ways:

• If MCA is not installed: spawns by replacing a newly spawned Minecraft villager
• If MCA is installed: spawns by replacing a newly spawned MCA villager

[brandyyn]

Since Witchery werewolf villagers don't spawn in villages by default, I'll add a config option that controls whether Witchery integration werewolf villagers have a small chance to spawn in villages. These will also be MCA werewolf villagers if MCA is installed.

This feature will work in the following ways:

• If MCA is not installed: spawns by replacing a newly spawned Minecraft villager
• If MCA is installed: spawns by replacing a newly spawned MCA villager

if mca is installed can it also replace newly spawned mc villagers, because i have both spawning in my pack.

[Rozmir-Rohi]

I can try to add that in as well.

[Rozmir-Rohi]

I found out that Witchery does actually provide a small chance for normal villagers to be replaced with a werewolf villager when they spawn, so I don't need to add the feature for normal villagers.

Unfortunately, the only way I can add a chance for MCA villagers to become werewolves is by looking at the ticks they have existed in the world, (if a villager is under a certain amount of ticks, replace them with a werewolf villager). But the problem with this is that their ticks get reset every time a player reloads the world, so it will keep trying to replace MCA villagers with werewolf villagers even if they have already spawned for the first time for each time a player loads that world. Because of this, I think it would be safer not to add a chance for MCA villagers to become werewolves, either way, you will still be able to encounter MCA werewolves outside of villages if they spawn in wolf form at night.

[brandyyn]

I found out that Witchery does actually provide a small chance for normal villagers to be replaced with a werewolf villager when they spawn, so I don't need to add the feature for normal villagers.

Unfortunately, the only way I can add a chance for MCA villagers to become werewolves is by looking at the ticks they have existed in the world, (if a villager is under a certain amount of ticks, replace them with a werewolf villager). But the problem with this is that their ticks get reset every time a player reloads the world, so it will keep trying to replace MCA villagers with werewolf villagers even if they have already spawned for the first time for each time a player loads that world. Because of this, I think it would be safer not to add a chance for MCA villagers to become werewolves, either way, you will still be able to encounter MCA werewolves outside of villages if they spawn in wolf form at night.

haha yeah don’t worry about it, thanks for looking into it for me :)