RpNation / bbcode

RpNation's Official BBCode Implementation for Discourse

GNU General Public License v3.0

1 stars 3 forks source link

Added to lowercase during context free check #99

Closed blythechan closed 2 months ago

blythechan commented 2 months ago

Issue

98

Requirements Met

[code] and [CODE] are acting differently than expected no matter the bbcode involved. Resolve this.

Notes

A string array contained the lowercase version of code. Adding "CODE" switched all code blocks that showed html markups to show bbcode markup. The name variable should never be undefined from what I can tell so I tacked on a toLowerCase() in order to prevent us having to add to the string array.

Alteras1 commented 2 months ago

specific code is provided by https://github.com/JiLiZART/BBob/blob/4f9729c59fcf5b78c9fac70e27281809686f00f8/packages/bbob-parser/src/lexer.js#L90

100 fixes this issue via the preprocessor step instead as it isn't enough for just the bbob lexer to catch the code tag.