search

RuairiK / divesit.es

A web app for locating dive sites
2 stars 1 forks source link

Small-scale views should show aggregates instead of markers #1

Closed sdob closed 9 years ago

sdob commented 9 years ago

At small scales (e.g. full-country views) showing map markers for all dive sites in the viewable region presents the user with a lot of visual clutter. It would be better just to show a total - à la "20 sites in this quadrant of the region you're viewing" - until the user zooms in to around Admiralty chart scale.

sdob commented 9 years ago

Assume you've checked out https://developers.google.com/maps/articles/toomanymarkers

sdob commented 9 years ago

I know that there's a bug in the Angular directive but it could be worked around with pure JS event listening, perhaps.

RuairiK commented 9 years ago

It could, but that seems like a messy solution, according to https://github.com/angular-ui/angular-google-maps/issues/1047 it's been fixed on master so I'm going to try downloading the master branch and see if it fixes the issue, it will mean we'll have to manually upgrade the library until the fix is propagated to the bower version.

sdob commented 9 years ago

Oh yes, very fresh! Do you want to go ahead and fork them? I kind of feel like we're running out of enhancements to Compass's work :-D

RuairiK commented 9 years ago

Actually scratch my last comment, you can force bower to install from master, the bug is fixed and clustering is working I'll push the changes.

sdob commented 9 years ago

Lovely job - will sync my repo in the morning.

RuairiK commented 9 years ago

My last commits fix this so I'm closing it as completed.