search

RuanAragao / calculator

Create your own calculator
https://ruanaragao.github.io/calculator/
MIT License
27 stars 29 forks source link

General Purpose Calculator #24

Closed TIDYMOUSE closed 1 year ago

TIDYMOUSE commented 1 year ago

Closes #20

TIDYMOUSE commented 1 year ago

@RuanAragao Hello, this is one of my earliest basic js project, would be great if you can review it

RuanAragao commented 1 year ago

@RuanAragao Hello, this is one of my earliest basic js project, would be great if you can review it

No problem. Follow the changes I commented. If you have any questions, I'm here to help.

TIDYMOUSE commented 1 year ago

Thank You for responding @RuanAragao . May I know where have you commented the changes you require?

RuanAragao commented 1 year ago

Thank You for responding @RuanAragao . May I know where have you commented the changes you require?

In the header of this section, there is a navigation bar, the last item is "Files change". You can see the comments in the code.

You can see here above, there is an automatic comment from me: "RuanAragao started a review"

TIDYMOUSE commented 1 year ago

Hello, @RuanAragao I cannot see any reviews/changes asked by you. Also you havent assigned yourself as a reviewer and me as an assignee.

RuanAragao commented 1 year ago

@TIDYMOUSE

  1. The main file in the calculator folder needs to be called "index.html".
  2. Review the general index.html, it has a repeated link.
TIDYMOUSE commented 1 year ago

@RuanAragao I have made the requested changes

TIDYMOUSE commented 1 year ago

@RuanAragao please respond

RuanAragao commented 1 year ago

@TIDYMOUSE The link is still broken <a href="./calculators/general-purpose-calculator/cal.html"

TIDYMOUSE commented 1 year ago

done @RuanAragao