search

Ruben2776 / PicView

Fast, free and customizable image viewer for Windows 10 and 11.
https://picview.org
Other
939 stars 63 forks source link

Some languages do not work and other issues #114

Open rellikmil opened 1 year ago

rellikmil commented 1 year ago

Hi there, I moved from ImageGlass because the author put some EULA there. I have to admit that PicView is even simpler than ImageGlass. However, I have a few questions.

I select Russian, but French is set. (I don't know why the list of languages is in Russian, although the default is English; but yeah, Windows on Russian) изображение

If I select Polish, Chinese is enabled (it's not on the list, "китайский" on Russian); if I select French, Korean is enabled; if I select Romanian, Polish is enabled изображение изображение

I also found that the settings window is truncated and you can't scroll down изображение

One last question: how do I make the default file associations enabled in Windows?

rellikmil commented 1 year ago

If you delete two lines (zh_CN and zh_TW) and reassemble, it will work. But I don't know how to add it in a smart way. изображение Apparently, somehow, Chinese languages didn't make the list.

rellikmil commented 1 year ago

One last question: how do I make the default file associations enabled in Windows?

Yeah, I can make it with "Open file as", but it would take a long time if I put each format (PNG, QOI, etc.) separately like this.

Ruben2776 commented 1 year ago

The list is in Russian because it gets the translation from your installed version of Windows. I may or may not make a different solution for it.

I'm looking into making a new window where you can select file associations in a future release.

I've tried to make a new version, where I've added scrollbar to the settings window and I've changed the language selection bias. Can you try and see if it fixes it for you? https://sourceforge.net/projects/picview/files/1.9/issue%20114/

rellikmil commented 1 year ago

No, nothing has changed in the languages. The problem is Chinese, because there are two. изображение I think it should be zh-Hans and zh-Hant, exactly with dashes, but dashes are not allowed in enumerations, so therein lies the problem. This probably needs to be rewritten somehow, but now I've built a program for myself, so for now, this is the solution.

As for Settings, cool, but UI settings needs scrolling, and size correction too изображение изображение

Ruben2776 commented 11 months ago

I've changed the the language selection logic. Does the latest commit work for you?

rellikmil commented 11 months ago

Yep, works fine, many thanks