search

RubenVerborgh / AsyncIterator

An asynchronous iterator library for advanced object pipelines in JavaScript
https://rubenverborgh.github.io/AsyncIterator/docs/
Other
49 stars 7 forks source link

fix: re-enable IterableSource options in wrap #80

Closed jeswr closed 2 years ago

jeswr commented 2 years ago

Prior to this fix uses of wrap following the pattern

const iterator = new EventEmitter();
wrap(iterator, { autoStart: false })

were breaking due to the fact that the type overloads did not include the optional option

RubenVerborgh commented 2 years ago

Thanks for finding this! Isn't just removing the overloads altogether the easier option? 25085c4a5b2f5fa5f15979cc8f9266e42465cfa3

jeswr commented 2 years ago

Isn't just removing the overloads altogether the easier option?

Seems like the sensible option to me @RubenVerborgh - could you release the current state of the main branch as 3.6.1 unless @jacoscaz has any objections?

jacoscaz commented 2 years ago

No objections!

RubenVerborgh commented 2 years ago

Thanks both! https://www.npmjs.com/package/asynciterator/v/3.6.1