Implicit grouping by count throws 120

danielbeeke commented 3 years ago

Hi Ruben and others,

I think I may have finished #120.

Renamed skipUngroupedVariableCheck to skipValidation
Added skipValidation to readme
I did not find other places where adding skipValidation looked useful. If this is incorrect I can add it.
Added a new folder for testing queries that only work while skipping the validation
Added one query that should have been added before. It was at the top of #120
Fixed the call to .map when there was no array
Spec seems to work, tests also. It does however give notices about .tsv files.

danielbeeke commented 3 years ago

One small thing that I am wondering about.. the names of the queries do they have a relationship with the spec? If so I might need to rename the newly added queries.

RubenVerborgh commented 3 years ago

the names of the queries do they have a relationship with the spec?

Yes, queries like sparql-10-2-2c.sparql point to section 10.2.2 of the spec.

So probably best to rename indeed.

rubensworks commented 3 years ago

Thanks @danielbeeke!

Spec seems to work, tests also. It does however give notices about .tsv files.

You can ignore this, it's a warning that is unrelated to SPARQL.js.

RubenVerborgh commented 3 years ago

All good, thanks!

RubenVerborgh / SPARQL.js

Implicit grouping by count throws 120 #145