search

RubenVerborgh / Solid-React-Components

Core React components for building your own Solid components and apps
https://rubenverborgh.github.io/Solid-React-Components/
MIT License
118 stars 21 forks source link

Feature/improved gitignore #2

Closed eduardoinnorway closed 6 years ago

eduardoinnorway commented 6 years ago

Simple improvement to avoid unnecessary commits as this projects grows.

RubenVerborgh commented 6 years ago

Thanks for the suggestion, but I believe many of these belong in the developer's global .gititnore file. Also duplicate coverage and most entries we don't need.

If that's okay with you, I like to keep the .gititnore file specific to this project, which brings more clarity in my opinion. What do you think?

(In any case we don't need the version bump.)

eduardoinnorway commented 6 years ago

Ok. Just suggestion is that when you get Readme running, just point out that devs should not pull request with things not related to this project, else you will get a ton of .idea/, .DS_STORE etc.. and it can get frustrating :(

What is your ambition with this project? I am interested in setting up a Atomic Design / React / BEM ... boilerplate for Solid, that is the reason I stumble in here. I have to sleep now, it is late in Norway, but I will follow this repo and do some laborations on my fork.

RubenVerborgh commented 6 years ago

else you will get a ton of .idea/, .DS_STORE etc.. and it can get frustrating :(

Ah interesting, have you had this happen a lot? I can't recall having this happen to me, and if it would, I'd use it as an opportunity to tell them about global .gitignore 😄

What is your ambition with this project?

Provide basic building blocks for people who want to build React apps with Solid. Or higher level: make building Solid apps easy and fun.

It's currently early stage, but I should do a first release soon, as it already has some of the important components to get started. Basically, I just need a README and some examples, and we should be good.

I am interested in setting up a Atomic Design / React / BEM ... boilerplate for Solid, that is the reason I stumble in here.

Very cool. Would you start a separate project and use the components from this one, or would it belong here?

I have to sleep now, it is late in Norway

Thanks for the reminder, late in Belgium too :wink: Keep me updated, and keep the good stuff coming. Curious to see how you can use this stuff.