Coupling to HTTP - Githubissues

RubenVerborgh / solid-server-architecture

Proposed architecture for a Solid server

https://rubenverborgh.github.io/solid-server-architecture/solid-architecture-v1-3-0.pdf

13 stars 2 forks source link

Coupling to HTTP #39

Closed rubensworks closed 4 years ago

rubensworks commented 4 years ago

This is an issue to make sure that we keep in mind that this server could be extended to support non-HTTP protocols, such as IPFS. As far as I can see, the LdpHandler is the only component that has a link to the HTTP layer. So architecturally, I think we're good, unless I'm missing something.

Implementation-wise, it will be important that this LDP-HTTP link goes through some kind of dependency injection layer to allow pluggin in custom protocols (such as IPFS).

Related to #24.

RubenVerborgh commented 4 years ago

Good point; I have indeed minimized the dependency on HTTP to the extent I saw possible. The main driver was there to have a layered system, and specifically to go against the hard-to-test HTTP-handler-driven implementation of node-solid-server.

Concretely, changes would remain limited to:

The HTTP, which would be replaced.
The extractors/parsers/writers in the LDP and Authentication packages, which are protocol-specific.

Do we need any action on this?

rubensworks commented 4 years ago

Ok, perfect!

Do we need any action on this?

No, just making sure it was thought of, which it has. So feel free to close.

RubenVerborgh commented 4 years ago

The separation has been made more clear with an HTTP subpackage within LDP: https://rubenverborgh.github.io/solid-server-architecture/solid-architecture-v1-3-0.pdf