search

RubendeBruin / DAVE

DAVE - Design Analysis Visualization and Engineering
Mozilla Public License 2.0
29 stars 7 forks source link

Name widget disappears from node-properties #165

Closed RubendeBruin closed 1 month ago

RubendeBruin commented 1 month ago

Reproduceable after running spectral response.

Build -> spectral response -> close sr window -> node-name is gone

RubendeBruin commented 1 month ago

Actually, ALL property editors disappear when they are open in a second window. This is because they are all Singletons.

node-name is added when the dock is created. At that moment is steals the instance.

Quick fix: remove the Singleton from the name-editor.

TODO: Why are the editors Singletons in the first place?

RubendeBruin commented 1 month ago

implemented in fix_165

RubendeBruin commented 1 month ago

In test locally, ready to be merged

RubendeBruin commented 1 month ago

merged