Open mancellin opened 1 year ago
Good point, update to:
if the checkbox is checked then "None" is passed as waterdepth
The UI looks good!
Capytaine might interpret water_depth=None
as infinite depth, but for robustness and future-proof-ness I would suggest using in your code the explicit standard floating point number representation of infinity water_depth=float('infinity')
.
Done,
in current master branch. Will be in next compiled version
I'm not sure 0 is a good default value for the water depth in Capytaine.
I don't mind using the "negative = infinity" convention used in other solver, but given the line
then entering
infinity
orinf
would givefloat('inf')
which is the actual floating point representation of infinity.