RubiconDeFi / rubi-subgraphs

Subgraphs for the Rubicon Protocol
MIT License
3 stars 0 forks source link

improvement: hardcoded stables #1

Closed denverbaumgartner closed 1 year ago

denverbaumgartner commented 1 year ago

today: we utilize the messar price oracle to get asset prices in a historical context 🌺 currently, we are using both an older version of the oracle (issues implementing newer version on first attempt) and a custom hardcoded stable price check 🥔 when syncing the BoilerPlate subgraph on Optimism mainnet there is a period of several 100K blocks where the USDC stable coin does not have a price feed, although other assets such as WETH do ❓ for situations like this, it is useful to be able to hardcode stable assets to 1 USD 🥇 the new price oracle does this in the config, our implementation does this in a hardcoded fashion that is chain agnostic, meaning it needs to be updated for the correct stable address on each network or else the subgraph will have unexpected behavior 😨

🔜 we should both update our pricing oracle to the most recent version that is released and update the optimism config to include the stable addresses we would like hardcoded as it does not already 🤔

denverbaumgartner commented 1 year ago

this should probably be fixed from the messari side? in an ideal world this would be a pr to that price oracle itself. i think im gonna close this because of that, but it would be great if this could be addressed ⌛🔜⏳