search

RubixDev / EnchantedShulkers

Adds some helpful enchantments for Shulker Boxes
https://modrinth.com/mod/enchantedshulkers
GNU General Public License v3.0
8 stars 6 forks source link

[Request] Different Siphon method #31

Closed Nitjsefnie closed 10 months ago

Nitjsefnie commented 11 months ago

This could be a level 2 Siphon or toggleable config, for some purposes it would be useful if it not only added to existing stacks, but created new stacks in case the existing stack is full.

RubixDev commented 11 months ago

this is a duplicate of #22, which i already have implemented locally

Nitjsefnie commented 11 months ago

This is NOT a duplicate. What I meant is for example you have cobblestone stack in a shulker, you pick up two more stacks of cobblestone and one stack of dirt, cobble ends up in shulker, dirt doesn't

RubixDev commented 11 months ago

Oh sorry, yea that sounds like a good idea to have as a config option to alter the behaviour of siphon

RubixDev commented 10 months ago

If you want to implement this yourself, I would add two config options to make Siphon or Vacuum behave like that. This way it is up to the user to just replace the Siphon functionality or to enable the Vacuum enchantment and override one of the enchantments with the new functionality. I don't think making this a level 2 would make sense and adding a new enchantment also seems a bit overkill.

I'd call the config options sth like siphonFillNewSlots and vacuumRequireItemPresent (I'm open to better names, they're not great) and make it clear in the descriptions that they both result in the same behaviour which is diffierent from any of the other enchantments.

In case you don't want to do the implementation, lmk and I will (eventually) do it myself.