RubixDev / EnchantedShulkers

Adds some helpful enchantments for Shulker Boxes
https://modrinth.com/mod/enchantedshulkers
GNU General Public License v3.0
8 stars 6 forks source link

Crash with Entity Texture Features on 1.20.1 #35

Closed bons66 closed 10 months ago

bons66 commented 10 months ago

MC 1.21.1 + Fabric 0.15.1 + large modpack (based on "Simply Optimized")

Crash with EnchantedShulkers 1.2.0 crash-2023-12-10_22.20.22-client.txt

Log with EnchantedShulkers 1.1.3 (OK) latest.log

Tested mods (no crash): adventurez-1.4.19.jar dehydration-1.3.5.jar sodium-fabric-mc1.20.1-0.5.3.jar indium-1.0.27+mc1.20.1.jar c2me-fabric-mc1.20.1-0.2.0+alpha.11.0.jar BarteringStation-v8.0.0-1.20.1-Fabric.jar PuzzlesLib-v8.1.11-1.20.1-Fabric.jar ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric.jar ForgeConfigScreens-v8.0.2-1.20.1-Fabric.jar brazier-fabric-6.1.1.jar bygonenether-1.20-1.3.2.jar

bons66 commented 10 months ago

After testing more than 300 mods... I found a conflicting mod. Entity Texture Features

MC 1.21.1 + Fabric 0.15.1 Mods - architectury-9.1.12-fabric.jar cloth-config-11.1.106-fabric.jar entity_texture_features_fabric_1.20.1-4.6.1.jar fabric-api-0.91.0+1.20.1.jar jei-1.20.1-fabric-15.2.0.27.jar modmenu-7.2.2.jar enchantedshulkers-mc1.20.1-v1.2.0.jar OR enchantedshulkers-1.1.3+1.20.1.jar

Crash with EnchantedShulkers 1.2.0 crash-2023-12-11_14.07.26-client.txt latest.log

Log with EnchantedShulkers 1.1.3 (OK) latest_OK.log

RubixDev commented 10 months ago

Looks like ETF v5.0 doesn't have this issue, but that's only available for Minecraft 1.20.2 onwards. I was however to get it working locally by playing with the Mixin priorities, just note that glint rendering on Shulker Boxes won't work with both the "Block entity random textures" and "Enable OptiFine random mobs" settings of ETF enabled. And fixing that is likely not easy, and I don't really want to put effort in that since it's already working with ETF v5.0.

RubixDev commented 10 months ago

The fix is available in v1.2.1 :tada: