RubixDev / EnchantedShulkers

Adds some helpful enchantments for Shulker Boxes
https://modrinth.com/mod/enchantedshulkers
GNU General Public License v3.0
8 stars 6 forks source link

Request: no embedded Polymer #58

Open MJRamon opened 2 months ago

MJRamon commented 2 months ago

Please remove Polymer as embedded library and add it as an optional dependency. Polymer is way too complicated mod for being used just as an embedded library, and can mess up server configuration. It's a server choice, not mod's choice that cannot be changed.

It has it's own implementations that could be unneeded or undesired, and thus needs additional config tinkering with something we don't need to or even cannot disable at all. Thank you.

RubixDev commented 2 months ago

Well Polymer isn't an optional dependency atm, it is required. Could you give an example how it messes up server configuration?

MJRamon commented 2 months ago

This is request, not report, that's why it is phrased like that. I am talking about it being required and embedded.

  1. Obvious thing: more mods - more maintenance and unexptected outcome.
  2. This use case scenario of Polymer can be optional, so why is it required?
  3. Polymer heavily intrudes into entity spawn, resource pack distribution, packet handling, blockstates, light updates, block update logic, itemstacks and many more. This is something simply not everyone needs on the server, and in case of use of many hundreds of mods, can lead to conflicts and errors that sometimes very hard to track.