search

RubixDev / Inventorio

Inventorio - an inventory enhancement mod for Minecraft (Fabric / (Neo)Forge)
https://modrinth.com/mod/inventorio
57 stars 19 forks source link

Sword items isn't working on the toolbar's sword slot. #330

Closed SireAwfulThe1st closed 3 months ago

SireAwfulThe1st commented 3 months ago

https://github.com/RubixDev/Inventorio/assets/106896635/3246cad0-9b95-4646-805b-989f91bf40b6

Sword items randomly stopped working in the sword slot of the toolbar, not sure if it's a sudden bug or an underlying mod causes this

RubixDev commented 3 months ago

Try disabling Jade for now. I'll try to fix this asap.

RubixDev commented 3 months ago

nvm, this might not be Jade. I'll have to try around myself to see what causes this. In the meantime could you send me your mod list?

RubixDev commented 3 months ago

Yea, this isn't Jade this time. I'll need a list of mods before I can find the issue. It doesn't seem to happen standalone.

SireAwfulThe1st commented 3 months ago

nvm, this might not be Jade. I'll have to try around myself to see what causes this. In the meantime could you send me your mod list?

Hello! I'm really sorry for the late reply, almost forgot that I had this issue open, with that said, sure my modlist will be in this modrinth pack if you don't mind.

https://drive.google.com/file/d/1jgMB_gQgPmjATcdPkTZw05d76ruM7Mg0/view?usp=sharing

RubixDev commented 3 months ago

The issue seems to be with ChainMailed. I was able to reproduce this in a minimal setup using only ChainMailed and Inventorio (plus dependencies).

RubixDev commented 3 months ago

Well duh, they completely redefine the player's attack method instead of only tweaking it slightly, and they don't even use an @Overwrite which would cause a crash indicating that the two mods are incompatible. This will have to be fixed on their end, that code is just bad in its current state and there's not much Inventorio can do about that.