search

RubixDev / rustmatica

A Rust crate for working with Minecraft litematica files
https://crates.io/crates/rustmatica
GNU General Public License v3.0
10 stars 2 forks source link

Update lists to Minecraft 1.20.1 #4

Closed newtykip closed 1 year ago

newtykip commented 1 year ago

Closes #2.

I also rewrote the logic for the data extractor such that it no longer needs a dummy world - for some reason I kept having issues with the damagetype registry when using that method on 1.20.1

RubixDev commented 1 year ago

Thanks! The DataExtractor was always a bit janky (the source-parser even more so). I used the dummy world technique before because it felt wrong to auto-accept the EULA in a script, but oh well, it's cleaner and easier this way.

newtykip commented 1 year ago

Thanks! The DataExtractor was always a bit janky (the source-parser even more so). I used the dummy world technique before because it felt wrong to auto-accept the EULA in a script, but oh well, it's cleaner and easier this way.

If the auto-acceptance of the EULA is that big of a deal you could just ask for user confirmation in the script. I just kinda assumed anyone who would want to run that script in the first place would consent.