search

RubixML / Tensor

A library and extension that provides objects for scientific computing in PHP.
https://rubixml.com
MIT License
223 stars 27 forks source link

Fix installing extension with pecl #14

Closed mlocati closed 3 years ago

mlocati commented 3 years ago

Fixes #13

github-actions[bot] commented 3 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mlocati commented 3 years ago

I have read the CLA Document and I hereby sign the CLA

andrewdalpino commented 3 years ago

This is fantastic @mlocati thank you!

The only problem is that Zephir overwrites this file upon compilation. This is the second issue we are facing due to the lack of support for editing the config.w4 file directly. See https://github.com/RubixML/Tensor/pull/11 also.

Here is the response I received from the Zephir people https://github.com/RubixML/Tensor/pull/14

I think I'll reach out one more time and see if we can work together on a solution. Note that this particular issue might also be a bug with Zephir. If not, we could always drop Zephir and code in plain C.

Thoughts?