search

RubixML / Tensor

A library and extension that provides objects for scientific computing in PHP.
https://rubixml.com
MIT License
229 stars 28 forks source link

Make it easier to install extension on Alpine Linux #20

Closed mlocati closed 3 years ago

mlocati commented 3 years ago

Fix #19

github-actions[bot] commented 3 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mlocati commented 3 years ago

How is the patch supposed to be run now that composer won't be able to find the patch script when we call $ composer compile?

Whoops, I missed that composer script!

BTW, I think that https://github.com/RubixML/Tensor/blob/2.2.0/composer.json#L68-L69 is logically wrong.

  1. zephir build --no-dev is the same as calling these commands in sequence:
    1. zephir generate
    2. zephir compile --no-dev
    3. zephir install --no-dev
  2. extension-config-patch.php is meant to patch the result of zephir generate before the extension gets compiled with zephir compile

So, at the moment (version 2.2.0), we patch config.m4 after it's being used.

I've updated the composer compile script so that we patch config.m4 before it's being used.