search

RubixML / Tensor

A library and extension that provides objects for scientific computing in PHP.
https://rubixml.com
MIT License
229 stars 28 forks source link

Link against libopenblas.lib on Windows #24

Closed cmb69 closed 2 years ago

cmb69 commented 2 years ago

Without a respective lib, linking would inevitably fail. We also add a check for cblas.h, and if either is not found, disable ext/tensor with a respective warning.

See also https://github.com/RubixML/Tensor/issues/22.

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

cmb69 commented 2 years ago

I have read the CLA Document and I hereby sign the CLA

cmb69 commented 2 years ago

recheck

cmb69 commented 2 years ago

Ah, I see! I wouldn't know, though, how to adapt the build script. If you can do it, please go ahead. :)

andrewdalpino commented 2 years ago

Hey @cmb69, I haven't been able to find the documentation to get an understanding of this or anything in the config.w32 file. From what I gather so far, it's Javascript with GNU Automake macros. However, the closest docs I found are here https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/autoconf.html#index-AC_005fCHECK_005fLIB but the macro signatures are different.

Can you explain what exactly is going on here? Also, is it necessary to compile on Windows or is it just a convenience? Apologize for my ignorance but again, this file is supposed to be handled by the Zephir compiler and I have been relying on it so far to give us the correct configuration. Thank you!