sneakyimp
commented
1 year ago EDIT: I managed to compile your Update code. Details below
On my Ubuntu 20.04 workstation (running PHP 8.2), I have carefully followed the instructions for Manually Compiling the Extension except instead of cloning the RubixML repo, I clone your myfuxi one instead:
# not this repo
# git clone https://github.com/RubixML/Tensor
# this one instead!
git clone https://github.com/myfluxi/Tensor
# and check out Update for PHP 8.2
git checkout a6c229b762af5227a85db295e1d7451ab7edc8e9
# continue with other steps...I had to fiddle with my PHP ini files in CLI and FPM folders, etc., but I now see the Tensor extension listed. I then tried to run this script, which loads a 1375x1966 matrix out of a JSON file and tries to multiply it by its inverse. It ends with a segfault:
<?php
/**
* script to try and use the PECL tensor extension to train a spam filter
*/
$json_file = realpath(__DIR__ . '/../training_data_sets.json');
$data = json_decode(file_get_contents($json_file), TRUE);
echo "rows: " . sizeof($data['Xtrain']) . "\n";
echo "cols: " . sizeof($data['Xtrain'][0]) . "\n";
use Tensor\Matrix;
$m = new Matrix($data['Xtrain']);
$mt = new Matrix($data['Xtrain']);
$mt->transpose();
$start = microtime(TRUE);
$mr = $m->multiply($mt);
echo (microtime(TRUE) - $start), " seconds elapsed for multiply\n";
//$arr = $mr->asArray();
//echo "rows: " . sizeof($arr) . "\n";
//echo "cols: " . sizeof($arr[0]) . "\n";The result:
$ php bar2.php
rows: 1375
cols: 1966
Segmentation fault (core dumped)Bizarrely, if I remove the comments, this script claims to finish very quickly:
<?php
$json_file = realpath(__DIR__ . '/../training_data_sets.json');
$data = json_decode(file_get_contents($json_file), TRUE);
echo "rows: " . sizeof($data['Xtrain']) . "\n";
echo "cols: " . sizeof($data['Xtrain'][0]) . "\n";
use Tensor\Matrix;
$m = new Matrix($data['Xtrain']);
$mt = new Matrix($data['Xtrain']);
$mt->transpose();
$start = microtime(TRUE);
$mr = $m->multiply($mt);
echo (microtime(TRUE) - $start), " seconds elapsed for multiply\n";
unset($m);
unset($mt);
$v = $mr->asArray();
echo "rows: " . sizeof($v) . "\n";
echo "cols: " . sizeof($v[0]) . "\n";The result of the latter code:
rows: 1375
cols: 1966
0.054421901702881 seconds elapsed for multiply
rows: 1375
cols: 1966The latter dimensions are incorrect. Should be 1375 x 1375, I think.
Something seems very unstable here.
andrewdalpino
remicollet
mlocati
In case you need to move to PHP 8.2 before @andrewdalpino find's time to update Tensor:
https://github.com/myfluxi/Tensor/commit/a6c229b762af5227a85db295e1d7451ab7edc8e9