search

RubixML / Tensor

A library and extension that provides objects for scientific computing in PHP.
https://rubixml.com
MIT License
223 stars 27 forks source link

Update prototypes in extension code #36

Closed myfluxi closed 2 months ago

myfluxi commented 1 year ago

Fixes a few deprecation warnings such as

Return type of Tensor\Vector::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

myfluxi commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

andrewdalpino commented 1 year ago

Hey this is great @myfluxi, I'll take a look at this ASAP

FxNion commented 1 year ago

Seems something is broken here ?

myfluxi commented 1 year ago

It is an unrelated test failing later in the process. This patch fixes some warnings which at least lets the extension compile during testing.

mlocati commented 9 months ago

The problem with this PR is that the code in the ext directory is automatically generated by zephir starting from the code in the tensor directory.

So, the fix should be performed in the tensor directory, like I'm suggesting in #39 (in particular, see 49f8b9e12ccf3d9570e859f0ff770f9b9f0d3282).

andrewdalpino commented 9 months ago

Hey thanks fellas, much appreciated! Do we still need this code since we merged @mlocati's code?

andrewdalpino commented 2 months ago

Closing this because I think this issue has been solved in a different PR.