search

RubricLab / create-rubric-app

CLI tool to get started with a full-stack AI project.
https://todo.rubric.sh
Other
138 stars 9 forks source link

Use Platform-specific Native Commands #13

Closed arihanv closed 1 year ago

arihanv commented 1 year ago

Changes to resolve #2 .

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 1d957e863e24bc2bb3e5db5fea24a942146a4a15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | create-rubric-app | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

@arihanv is attempting to deploy a commit to the RubricLab Team on Vercel.

A member of the Team first needs to authorize it.

arihanv commented 1 year ago

Need to review/merge #12 first.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-rubric-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 4:43pm
tedspare commented 1 year ago

Awesome work again @arihanv!! Were you able to test on a Windows machine?

arihanv commented 1 year ago

Awesome work again @arihanv!! Were you able to test on a Windows machine?

Thanks! I wasn't since I use Mac, but the code was short and easy enough to read, so I just manually identified commands that are native only to Mac and added code to support them in windows. Would be good if someone tests it out, perhaps the original author of the issue.

DexterStorey commented 1 year ago

Still works on Mac. Dev and Build pass. Will merge to main and ask a windows friend to test latest in prod. LGTM, great work @arihanv!