search

RubyDevInc / paho.mqtt.ruby

Eclipse Public License 1.0
31 stars 19 forks source link

Fix issue #35 #45

Closed oldgreen closed 6 years ago

oldgreen commented 6 years ago

These changes fix the problem described under issue #35 (periodic disconnects when the client keeps frequently sending (only) QoS 0 messages). Please see the individual commit messages for details.

p-goudet commented 6 years ago

Thank you very much, I am checking at this approach to handle the ping message.

arizz96 commented 6 years ago

Any news here?

p-goudet commented 6 years ago

@oldgreen Thank you again for your contribution. There was a small issue remaining. After a reconnection, the client would stop trying to ping the server, because the last_pingresp_receive_at value would not be updated. I also did some small refactoring. I have issued a new pull request based on your work: https://github.com/RubyDevInc/paho.mqtt.ruby/pull/47

Could you tell me if those modifications are fine for you?

oldgreen commented 6 years ago

@p-goudet yes, please feel free to do any modifications. Thanks.

p-goudet commented 6 years ago

This change have been add in the following mergre request. https://github.com/RubyDevInc/paho.mqtt.ruby/pull/47 Thank you for your contributions