an option to pass read_timeout for rates updates

RubyMoney / eu_central_bank

A gem that calculates the exchange rate using published rates from European Central Bank. Compatible with the money gem

MIT License

217 stars 130 forks source link

an option to pass read_timeout for rates updates #100

Closed starbeast closed 3 years ago

starbeast commented 5 years ago

Time taken by update_rates call depends on response time of the European Central Bank servers and it's only possible to interrupt using Timeout::timeout (which can cause bugs) if the call is stuck in case I'd like to use a fallback bank. That would be great if I could pass timeout option to this call so it will be used by the underlying open call

antstorm commented 5 years ago

Sounds like a great idea, would you be up for opening a PR to add this?