Permit to automatically expire rates after a given amount of seconds

RubyMoney / google_currency

Ruby Money::Bank interface for the Google Currency exchange data

http://rubymoney.github.com/google_currency

MIT License

182 stars 90 forks source link

Permit to automatically expire rates after a given amount of seconds #21

Closed cover closed 11 years ago

cover commented 11 years ago

One think that I miss is the ability to automatically flush rates, especially when running on background jobs or webservers that aren't restarted frequently, with the risk of using days old rates. I've added this to permit to automatically expire all the rates after a given amount of seconds. I hope you find it useful too :)

semmons99 commented 11 years ago

Couple suggestions.

extract code in get_rate into a some type of expiration method.
use timecop to manipulate time in the spec instead of stubbing time
instead of overriding initialize, create a class instance variable like those used in the money gem
add info to the readme and your name to the contributors
rebase into a single commit

I wonder if this is possible to sideband in a thread...

cover commented 11 years ago

Let me know what you think about these changes

semmons99 commented 11 years ago

@cover awesome!