RubyMoney / google_currency

Ruby Money::Bank interface for the Google Currency exchange data
http://rubymoney.github.com/google_currency
MIT License
182 stars 90 forks source link

Increase rates precision #36

Closed printercu closed 9 years ago

printercu commented 9 years ago

I've changed amount in request to 1000. Seems like it'll increase precision with 3 digits for free. wdyt?

semmons99 commented 9 years ago

Looks like it changes results given the spec failure.

printercu commented 9 years ago

Yeah, it's stubbed. I can fix specs & readme if you like the idea.

semmons99 commented 9 years ago

I'm cool with that. Make sure to update the changelog too

printercu commented 9 years ago

I've checked, google doesn't round after conversion, but applies rounded rates. So there is no difference what amount is converted. Sorry.

yinquanteo commented 9 years ago

Yes, that's right, this is evident if you play around with Google Finance Calculator