search

RubyMoney / google_currency

Ruby Money::Bank interface for the Google Currency exchange data
http://rubymoney.github.com/google_currency
MIT License
182 stars 90 forks source link

Replaced www.google.com by finance.google.com #56

Closed smennesson closed 7 years ago

smennesson commented 7 years ago

Hi, it seems Google has changed something and that www.google.com/finance/converter is now redirecting to finance.google.com/finance/converter without giving the currency conversion. So the current version does not work any more. The fix is simple, I just had to replace www.google.com by finance.google.com

AlexWayfer commented 7 years ago

@smennesson, thank you for PR!

@semmons99, @antstorm, it's very important! Our server in Germany went down due to this unexpected behavior from Google (GoogleCurrencyFetchError). Please, accept this PR and release a new version of gem.

finance.google.com has text in footer:

Google Finance Beta available in: Hong Kong - Canada - U.S. - China - U.K.

And there is no redirect from Russian Federation.

Attempt to show region-based redirect: geopeeker.com (screenshot from Singapore has empty fields for me, which means the redirect was occured).

jirihradil commented 7 years ago

Just a notice, the url https://www.google.com/finance/converter still works for me (currently in Prague, Czechia, Europe).

antstorm commented 7 years ago

@smennesson thank you for the PR. It seems like both pages work fine for me, same goes for when trying to load the page via geokeeper.

antstorm commented 7 years ago

I will release the updated version later today

smennesson commented 7 years ago

@jirihradil https://www.google.com/finance/converter is still responding, but it is not acting like the gem is expecting. It is only redirecting to finance.google.com without displaying the currency conversion.

AlexWayfer commented 7 years ago

@jirihradil https://www.google.com/finance/converter is still responding, but it is not acting like the gem is expecting. It is only redirecting to finance.google.com without displaying the currency conversion.

In some regions it's still working without redirects (in Russian Federation, for example, as I said before). But this is not very predictable.