search

RubyMoney / money

A Ruby Library for dealing with money and currency conversion.
http://rubymoney.github.io/money
MIT License
2.75k stars 626 forks source link

CI is failing #1075

Closed tagliala closed 8 months ago

tagliala commented 8 months ago

df6525f39bcba80690604aa9e7eff48629809012 #1055 broke the CI

There are PRs fixing this, but they are mixed with other unrelated changes

tagliala commented 8 months ago

Actually this looks more complex than a spec failing

https://github.com/RubyMoney/money/blob/092ecc7a711263208ae12fd62e7538f3d7a6348a/spec/money/formatting_spec.rb#L761-L767

It is not expected that symbol_position: :before and symbol_position: :after behave differently, with the latter adding a space

edit:

according to

https://github.com/RubyMoney/money/blob/092ecc7a711263208ae12fd62e7538f3d7a6348a/lib/money/money/formatting_rules.rb#L87-L91

It is surprising but it is an expected default, and changing this behaviour would be a breaking change

tagliala commented 8 months ago

It has been fixed in 6.19.0