RubyNepal / rorh

wiki for Ruby on Rails Himalayas (https://github.com/RubyNepal)
10 stars 1 forks source link

Maintaining Coding Standards with RuboCop, Overcommit, Pronto and Gitlab CI #27

Closed coolprobn closed 1 year ago

coolprobn commented 2 years ago

Abstract

When working with the team it's crucial to maintain coding standards and write the code that adheres to best practices. This can generally be achieved with code reviews. But code reviews is for fruitful and logical discussions and not for discussions related to using single or multi quote, leaving blank lines after each methods, separating different code, etc... This can easily be achieved if we use code analyzer like RuboCop which helps to configure rules which all members in the team can follow once finalized with discussion.

This can further be made effective with overcommit, a gem for managing git hooks. This makes sure that code with warning or errors from RuboCop is never committed to the git repo. And with CI like Gitlab CI, it can also be checked if someone bypassed RuboCop in their local machine assuring that code that is committed has followed the best practices followed by best developers all around the world.

Speak or Suggest

NOTE: I have never given a talk before

Intended Audience

Talk Duration

Bio / About the author

Hi 👋 I am Prabin Poudel, Senior Ruby on Rails Engineer, Freelancer and CEO of Truemark Technology

I have been working with Rails for past 4 years and involved in a lot of code reviews inside our organization. At Truemark we take coding standards and quality very seriously and we use tools mentioned above to maintain best practices in all our projects.


josisusan commented 2 years ago

Thanks Prabin, this would be an awesome topic for the meetup. Would like to know your availability for next weekends (ie 18th Dec)

coolprobn commented 2 years ago

@josisusan What will be the agenda for our meeting? I will have to make time.

josisusan commented 2 years ago

I thought you want to speak on the topic. No hurry, we can take time to organize meetup. @coolprobn

coolprobn commented 2 years ago

Yes, I want to speak on this.

I am extremely busy for some weeks and I haven't even prepared slides for presentation 😅

zoras commented 2 years ago

Hey @coolprobn, did you manage to carve out some time for the slides?

jonathanclarke commented 1 year ago

@coolprobn did you want to talk on this tomorrow night?

coolprobn commented 1 year ago

@jonathanclarke I was not able to allocate time to create Presentations for this talk. I have done that now and am ready to give the talk. Please let me know when the next talk is and how I should collaborate for you to review these slides.

jonathanclarke commented 1 year ago

@zoras can you follow up?

zoras commented 1 year ago

Hi @coolprobn, can you share the slides on slack with me? We can do the meetup on Jan 17 if it works for you?