As a user, I want to see the image of the instrument

RubySpeeders / Drum-Roulette

https://drum-roulette.vercel.app

3 stars 3 forks source link

As a user, I want to see the image of the instrument #6

Closed RubySpeeders closed 1 year ago

RubySpeeders commented 1 year ago

like the musicians, for now we can use images and save them as files in the project
@cheesehero112 can I task you with finding the best photos of the percussion instruments? Since you are our percussion expert 🥇
the six instruments are: tenor drum, snare drum, bass drum, cymbals, and bass drum + cymbals

cheesehero112 commented 1 year ago

I can do that. Did we agree on the background being white or transparent?

RubySpeeders commented 1 year ago

Let's go with white for now -- I'm thinking it will be easier to do that? But if transparent is easier, go with that.

cheesehero112 commented 1 year ago

@RubySpeeders > Working on showing added images. I'm seeing this warning that I have to figure out. Also, in general, trying to learn how to custom style Material UI components.

RubySpeeders commented 1 year ago

@cheesehero112 I think that error might be my fault! I would ignore it for now. Were you able to figure out styling?

cheesehero112 commented 1 year ago

@RubySpeeders Ok - let me know if you have a good guess on how to fix the error. Re: styling - Not yet! I will look into it this week.

cheesehero112 commented 1 year ago

@RubySpeeders @charlottekies > Just made a PR to address this ticket. Let me know if you have any questions or feedback!