search

Rubydesic / minecraft-dynamic-discs

GNU General Public License v3.0
7 stars 9 forks source link

Update to 1.18.2, fix Linux audio #11

Open wordandahalf opened 2 years ago

wordandahalf commented 2 years ago

Fixes #10, #4, and #2

wordandahalf commented 2 years ago

Untested in multiplayer. I did run into an issue where the clip would cut out after a certain amount of time with an error in console, invalid as first byte of an EBML number. Unsure if it is due to e7eb31a (unlikely) or something else.

Rubydesic commented 2 years ago

Why change mappings?

Rubydesic commented 2 years ago

Also this doesn't even compile for me

Rubydesic commented 2 years ago

Ok, I made it compile by updating the build script a bit but this breaks the mono conversion which allows us to have directional audio from the jukebox... not good.

@wordandahalf if you test the linux-fix branch, does that work for you? I assume not.

Rubydesic commented 2 years ago

final comment - does this work for you outside of dev environment? I'm having some problem where it seems to have stopped working outside of the dev environment in 1.17+ and I can't figure out for the life of me why.

wordandahalf commented 2 years ago

Ok, I made it compile by updating the build script a bit but this breaks the mono conversion which allows us to have directional audio from the jukebox... not good.

@wordandahalf if you test the linux-fix branch, does that work for you? I assume not.

Yes, I tested the fix you had, and it only produced very loud, random noise.

wordandahalf commented 2 years ago

final comment - does this work for you outside of dev environment? I'm having some problem where it seems to have stopped working outside of the dev environment in 1.17+ and I can't figure out for the life of me why.

I didn't bother testing it very extensively, only on my Ubuntu 20.04.1 desktop.

wordandahalf commented 2 years ago

Why change mappings?

I used the most recent build script and settings from the Fabric example repository. So, no real reason other than to adhere to the "standard."

Rubydesic commented 2 years ago

final comment - does this work for you outside of dev environment? I'm having some problem where it seems to have stopped working outside of the dev environment in 1.17+ and I can't figure out for the life of me why.

I didn't bother testing it very extensively, only on my Ubuntu 20.04.1 desktop.

Ok, thank you for the Linux audio fix, I will use your fix but I will not port to 1.18.2 until I can fix the issue with no sound output when running the mod normally. Not sure what's causing it because there is no error message.