search

RuckusWirelessIL / pentaho-kafka-consumer

Apache Kafka consumer step plug-in for Pentaho Kettle
Apache License 2.0
66 stars 40 forks source link

Code quality #28

Closed NicolasReyrolle closed 6 years ago

NicolasReyrolle commented 6 years ago

I used sonar to identify code smells, and solved them according to the standard sonar way

spektom commented 6 years ago

Hello @NicolasReyrolle,

  1. Can you check what's wrong with code formatting please?
  2. This PR makes the build fail. Is it something related to your changes?

Thanks, Michael

NicolasReyrolle commented 6 years ago

Hi,

I do not understand what happened with the formatting. I accidentally ticked reformat code in IntelliJ, and it seems that it led to that. But it looks correct to me (except the multiple modifications). Do you have rules for that?

For ui-swt:4.6, do no know what is happening. It is building locally, but I had similar issues during the week when building PDI. I did not spend time to figure what was happening. Can you retrigger the build?

NicolasReyrolle commented 6 years ago

Sorry, I did not notice, but my last push has triggered the build, but it failed again. I do not know what is happening, but I will try to investigate

NicolasReyrolle commented 6 years ago

After dependency clean-up locally, it now does not build anymore locally: [ERROR] Failed to execute goal on project pentaho-kafka-consumer: Could not resolve dependencies for project com.ruckuswireless:pentaho-kafka-consumer:jar:TRUNK-SNAPSHOT: Could not find artifact org.eclipse.swt:org.eclipse.swt.gtk.linux.x86_64:jar:4.6 in pentaho.resolve.repo (http://nexus.pentaho.org/content/groups/omni) -> [Help 1]

I do not really understand what is happening, but the 4.6 library is (obviously) not here (https://public.nexus.pentaho.org/content/groups/omni/org/eclipse/swt/), but the modification dates seem to be changed. In any case, this dependency is brought by the parent pom.

To be honest I am bit stuck on this. Any idea?

Nicolas

spektom commented 6 years ago

Thank you @NicolasReyrolle, I've figured out what was the problem. Created new PR #29 based on this one.