RuckusWirelessIL / pentaho-kafka-producer

Apache Kafka producer step plug-in for Pentaho Kettle.
Apache License 2.0
45 stars 33 forks source link

Annotation-based plugin architecure #16

Closed fhossfel closed 7 years ago

fhossfel commented 7 years ago

Since Pentaho 3.0.0.RC1 it is possible/recommended (?) to write Plugins using annotations instead of the old plugin.xml. However, there are some conventions to be honored - most notably the step has to be defined below org.pentaho.di.trans. The full documentation about annotation-based plugin development is available from the Pentaho wiki.

As I could not get the plugin up and running using the old style I have refactored the step to use the annotation-based approach. Not additional functional changes are included in this branch - the plugin works great. Thanks!

spektom commented 7 years ago

Looks great. Does this mean we stop supporting older Pentaho versions?

fhossfel commented 7 years ago

According to the documentation the annotation-based plugins are developed from 3.0.0-RC1.

The oldest version I have lying around here is 4.1.0 (released in 2010) and the plugin works fine there. So I assume it is save to say that older versions are supported.

spektom commented 7 years ago

@fhossfel Thank you for the contribution!