Fix values from real-time weather from a station

Rudd-O / homeassistant-meteoswiss

:sun_behind_rain_cloud: :switzerland: Meteo Swiss Integration for Home Assistant (forked from websylv)

74 stars 8 forks source link

Fix values from real-time weather from a station #16

Closed pascalfleury closed 8 months ago

pascalfleury commented 1 year ago

This contains essentially 3 changes:

simplify the reading of floats to have the error handling in a single place
make the reading of the value more robust to invalid values, like '-'
store the conditions as the dict directly, not as an array of 1 element that is the dict

This will address #14 at least partially.

pascalfleury commented 1 year ago

Note that the values seem to convert properly (from the system logs) but the read values from the UEB station are not the ones that are used in the integration (there are other values given the station is on a high mast).

I have some changes to the hamsclientfork lib that I will send you shortly for that.

TimMayle commented 1 year ago

I did not see your proposal before I did mine. Yours is much better than mine :)

pascalfleury commented 1 year ago

Do as you wish, I used it for me and it works. I still have issues with the actual values, given the UEB station is on a huge mast, and the values are from other sensors. I think this should be done in the hamsclient lib though.

also, if you want me to adjust the coding style, of divide the commits differently, let me know.

Rudd-O commented 8 months ago

Hey, thanks for this great effort. An almost identical change is now merged to master.