search

Rudd-O / homeassistant-meteoswiss

:sun_behind_rain_cloud: :switzerland: Meteo Swiss Integration for Home Assistant (forked from websylv)
92 stars 11 forks source link

Branding icon #25

Open jiiins opened 1 year ago

jiiins commented 1 year ago

It looks like the integration's icon is missing, both in HACS and locally after installation.

mastameista commented 1 year ago

+1 same here :)

Rudd-O commented 1 year ago

I'd like that too, but it doesn't look like I control this — I think this is controlled by HACS and I tried the process, only to be rudely told no (this is a very small summary).

If anyone knows how to add the integration icon, without having to go through HACS, I would gladly do so.

braetkuegeli commented 8 months ago

According this blog post it must done via brands:

If this icons are ok for you, I would create a pull request: https://github.com/home-assistant/brands/compare/master...braetkuegeli:brands:master

Rudd-O commented 3 months ago

@braetkuegeli yes please. Thank you for creating the PR there. I don't have access to create PRs in that repo. When that integration is merged in the brands repo, icon will just work.

Rudd-O commented 3 months ago

Leaving this open until such a PR is merged.

Superkikim commented 2 months ago

I've just looked at the pull request. And frenck is complaining about the icon being from the app.

He did exactly the same for me with my maxsmart integration. I couldn't sort it out (and took it quite personally I must say).

Rudd-O commented 2 months ago

Without too many details, I've gotten perfectly working PRs rejected from HA before. I understand your frustration.