Rudizind / quantum_minesweeper

1 stars 0 forks source link

A selection of comments, mostly style #9

Closed mtorpey closed 4 years ago

mtorpey commented 4 years ago

Hi Cameron! I just had a look through your code in its current state (commit 981d75c) and had a few comments.

Firstly, this is still great progress! It looks like you've already done most of what we talked about in our last meeting, and it seems to be working great, modulo those bugs you've spotted. Well done so far!

Most of my comments here are stylistic things. Some are quite fussy, but it'd be great to have a nice clean codebase for further work and for when it's being marked. Here goes...

I hope that's useful. I might have some other comments before we meet again, but if not, I'll see you Tuesday! We can discuss this and any other stuff then. :)

Please close this issue whenever it suits you.

Rudizind commented 4 years ago

Hi Michael! Many thanks for having a look through the code. I am somewhat embarrassed that I left in the comment from line 539 in solver.js - I should have thought to look at this before pushing my code! Apologies for that.

Re: all other suggestions, these are very helpful and I appreciate your feedback. I'll go through and implement those changes today and should have the code pushed in an hour or two. Other than these fixes, I will probably take a couple days off for the weekend as I haven't been very good at taking breaks.

Once I've made the changes you've suggested above, I'll push the code to the repo again. If I don't hear from you before then, I will see you on Tuesday for our meeting!