Rudloff / alltube

Web GUI for youtube-dl
GNU General Public License v3.0
2.94k stars 584 forks source link

Config option "convert: false" doesn't work #373

Closed v-bulynkin closed 2 years ago

v-bulynkin commented 2 years ago

Your environment

What version of AllTube are you using? Latest docker image - rudloff/alltube.

What is the content of your config/config.yml file?

appName: AWESOME
convert: false
convertAdvanced: false
stream: false
remux: false

Describe your issue

I simply use docker with copying a config file into the latest rudloff/alltube docker image. The appName option is working (which points out that the config file is in place), but convert is not. Why? I would like to remove the MP3 tab from the Alltube's frontpage.

Rudloff commented 2 years ago

The Docker image enables conversion with an environment variable: https://github.com/Rudloff/alltube/blob/eeda434b2fd61be1a9b4a49c35d5bda79fae1e78/Dockerfile#L13 And environment variables have a higher priority than the config file.

So you need to extend the Docker image to set CONVERT=0.

v-bulynkin commented 2 years ago

Great, it works, thank you! Are the environment variables documented somewhere (I haven't found) or they are equal to config parameters?

Rudloff commented 2 years ago

They are not documented (but pull requests are welcome). The environment variables are automatically derived from the YAML keys (for example appName becomes APP_NAME).