search

Rudloff / alltube

Web GUI for youtube-dl
GNU General Public License v3.0
2.94k stars 585 forks source link

Duplicate custom port in `<head>` URLs + bad URLs #410

Open schklom opened 2 years ago

schklom commented 2 years ago

New issue

Your environment

Please answer these questions when reporting a new issue:

What is your operating system (Windows, Linux, OSX, etc.)? Linux

What is your web server (Apache, IIS, etc.)? Default used with Docker

What version of AllTube are you using? Latest on DockerHub

How did you install AllTube (with Git or with a release package)? Docker

What version of PHP are you using?

What version of Python are you using?

What version of youtube-dl are you using?

Do you get any PHP-related errors in your webserver's logs?

What is the content of your config/config.yml file? Don't have one, the default is used.

Please provide the URL of a video that causes the issue.

Describe your issue

The website works, but it looks bad. Many URLs on the page header have a duplicated port. My website URL is https://AAAA.XXX:12345 (upper-case to make it easy to spot below) and e.g. the <head> is 

<head>
    <meta charset="UTF-8"/>
    <meta name=viewport content="width=device-width, initial-scale=1"/>
            <meta name="description" content="Easily download videos from YouTube, Dailymotion, Vimeo and other websites."/>
        <meta name="twitter:description" content="Easily download videos from YouTube, Dailymotion, Vimeo and other websites."/>
        <meta property="og:description" content="Easily download videos from YouTube, Dailymotion, Vimeo and other websites."/>
        <link rel="stylesheet" href="https://AAAA.XXX:12345:12345/assets/open-sans/open-sans.css"/>
    <link rel="stylesheet" href="https://AAAA.XXX:12345:12345/css/style.css"/>
    <title>AllTube Download</title>
    <link rel="canonical" href="[https://alltubedownload.net:12345/](view-source:https://alltubedownload.net:12345/)"/>
    <link rel="icon" href="https://AAAA.XXX:12345:12345/img/favicon.png"/>
    <meta property="og:title" content="AllTube Download"/>
    <meta property="og:image" content="https://AAAA.XXX:12345:12345/img/logo.png"/>
    <meta name="twitter:card" content="summary"/>
    <meta name="twitter:title" content="AllTube Download"/>
    <meta name="twitter:image" content="https://AAAA.XXX:12345:12345/img/logo.png"/>
    <meta name="twitter:creator" content="@Tael67"/>
    <meta name="theme-color" content="#4F4F4F"/>
    <link rel="manifest" href="https://AAAA.XXX:12345:12345/resources/manifest.json"/>
    <meta name="generator" content="AllTube Download (1.0.0+no-version-set@)"/>

    </head>

You can see that :12345 is duplicated in many URLs, and https://alltubedownload.net:12345 also appears even though I don't own that website.

Rudloff commented 2 years ago

Thanks for the report.

The Docker image has not been updated in a year and is not really maintained.

I tried running the latest AllTube on the 12345 port (without Docker) and the only issue I can reproduce is the https://alltubedownload.net:12345/ URL. This will be fixed in the next release: e53393d670c088271fe165daaeb0cc72886c2eab