search

Rudloff / openvegemap

Find vegetarian and vegan restaurants in your city
https://openvegemap.netlib.re/
GNU General Public License v3.0
72 stars 9 forks source link

Shops filter #61

Closed dimqua closed 5 years ago

dimqua commented 5 years ago

Is it possible to do not display shops if they're not vegetarian-friendly on the map?

hermann-san commented 5 years ago

good point, I've checked for Berlin and I can see 4 backery shops that are in "unknown" status. I don't understand why they are there. Maybe someone added those as potentially veggie, but it needs to be verified at the location itself.

I believe that those shops can't be filtered in the current app version (I'm not a developer though).

dimqua commented 5 years ago

I've have seen a butchery shop marked as "unknown". :-D

Besides, vegetarian/vegan shops use the same marker as restaurants, IMHO it's confusing.

Rudloff commented 5 years ago

Unknown is when the node has a diet: key but not for vegan/vegetarian (probably another diet like gluten-free), it is mostly useful for people who are actively contributing and are looking for incomplete data to fix.

I think I will make the shops follow the general filters setting so if you hide non-vegetarian restaurants, it will hide non-vegetarian shops as well.

dimqua commented 5 years ago

@Rudloff these places are displayed on the map as unknown: https://www.openstreetmap.org/node/5024383123 (diet:halal) https://www.openstreetmap.org/node/3629353839 (diet:kosher) with the default filter set (non-veg restaurants aren't enabled).

Rudloff commented 5 years ago

https://github.com/Rudloff/openvegemap/commit/f0eb8ef21f73d7b77e1de1f0c5b032141096f8a1 is still only on the develop branch. It will be included in the next release and this will make this kind of shop only appear if the Not vegetarian filter is checked.