search

Rudloff / openvegemap

Find vegetarian and vegan restaurants in your city
https://openvegemap.netlib.re/
GNU General Public License v3.0
72 stars 9 forks source link

favicons (build with https://realfavicongenerator.net) #84

Closed KristjanESPERANTO closed 4 years ago

KristjanESPERANTO commented 4 years ago

With the Favicon checker [1] you can check "more than a dozen settings to make sure it fits all major platforms". The result of openvegemap.netlib.re shows that there are some gaps [2]. This pull request should fill those gaps.

[1] https://realfavicongenerator.net/favicon_checker [2] https://realfavicongenerator.net/favicon_checker?protocol=https&site=openvegemap.netlib.re%2F

KristjanESPERANTO commented 4 years ago
  • Why does apple-touch-icon.png have non-transparent background?

The generator explains it that way: "Your favicon is transparent. This is usually a good thing, but not for iOS Web Clips which are supposed to be opaque." + "iOS will fill the transparent regions with black."

Black isn't a suitable background color I think.

  • favicon-32x32.png is somehow larger and more pixelated than the original logo_32.png file.

I didn't notice any deterioration. See my screenshot here:

Ekrankopio de 2020-10-20 09-27-49

Regardless of my impression, I've just renamed the old logo_32.png and replaced favicon-32x32.png with this one.

  • Shouldn't every PNG image be added to the manifest?

I'm not sure, but I don't think this would be necessary.

I will try to queue up smaller pull requests in the future so that you have it easier to review.

Rudloff commented 4 years ago

Black isn't a suitable background color I think.

Fair enough. Maybe use a white background instead?

KristjanESPERANTO commented 4 years ago

Fair enough. Maybe use a white background instead?

White doesn't look good. Now I changed it also to the green from the logo. I think, that's a good solution :slightly_smiling_face: