Empty window with no content displayed

Rudloff / viatcheslav

Open-source client for Molotov.tv

GNU General Public License v3.0

4 stars 0 forks source link

Empty window with no content displayed #11

Closed Kabouik closed 5 years ago

Kabouik commented 5 years ago

Hey @Rudloff, here's my monthly report of a new issue after molotov.tv breaks the compatibility with third party apps again! Since today (or maybe just a couple days ago), Viatcheslav stopped displaying the content of molotov.tv again:

Also, a more minor issue: in one of the commits you made a few months ago to fix an issue with the layout, you added a grey block at the top of the interface in order to push the content down and avoid some elements to superimpose. However, the offset is also visible and wastes some of the screen estate when using the full screen mode (F11). Would you have a more elegant workaround in mind?

Rudloff commented 5 years ago

Molotov is looking for a variable that does not exist in Viatcheslav. It should be fixed on the develop branch now.

As for the space on top, it is not caused by my workaround. This space is used to display the window buttons in the official app (Viatcheslav uses native windows buttons, but in the official app the buttons are included in the webview). I will see if I have a simple way of removing it.

Kabouik commented 5 years ago

Confirmed to work perfectly with develop. Thanks again for the swift fixes @Rudloff!

Rudloff commented 5 years ago

I pushed a workaround for the margin issue on develop. Can you check if it works for you?

Kabouik commented 5 years ago

Seems to work pretty well, thanks.

However I'm getting several warnings at npm install that npm audit fix (including with the --force argument) doesn't seem to fix. I am not sure it is related, but just in case:

kabouik@xiaomimi-solus ~/.config/viatcheslav $ npm install

> electron@4.0.4-wvvmp postinstall /home/kabouik/.config/viatcheslav/node_modules/electron
> node install.js

npm notice created a lockfile as package-lock.json. You should
commit this file. added 338 packages from 512 contributors and
audited 723 packages in 14.389s found 7 vulnerabilities (2 low, 2
moderate, 3 high)
  run `npm audit fix` to fix them, or `npm audit` for details

Rudloff commented 5 years ago

Thanks for telling me. I will try to update some of the dependencies, then I will publish a new release.

Kabouik commented 5 years ago

Unfortunately, seems to be broken again @Rudloff. Hope you don't mind fixing things up every time Molotov.tv do their shenanigans.